Code Review

Change: Automated dependency update bumping from → (patch release), via Renovate bot.

What Changed

Single line in — a patch version bump.

Assessment

This is a safe, low-risk update. The 18.5.1 release notes document a bug fix:

Fix System.Collections.Immutable binding mismatch in Common.dll

That's a genuine correctness fix worth picking up — a binding redirect mismatch can surface as subtle runtime errors depending on transitive dependency graph resolution.

Note on CLAUDE.md Guidance

The project's CLAUDE.md states "No VSTest — use Microsoft.Testing.Platform only." Worth clarifying for future contributors: Microsoft.NET.Test.Sdk is not the VSTest runner itself — it's the MSBuild SDK package that wires up dotnet test integration and is required even when using Microsoft.Testing.Platform. The banned package is Microsoft.VisualStudio.TestPlatform. This update is consistent with the project's stated approach.

Verdict

✅ Good to merge. Straightforward patch bump with a useful bug fix and no API or behavior changes.

Code Review

Change: Automated dependency update bumping Microsoft.NET.Test.Sdk from 18.5.0 → 18.5.1 (patch release), via Renovate bot.

What Changed

Single line in Directory.Packages.props — a patch version bump.

Assessment

This is a safe, low-risk update. The 18.5.1 release notes document a bug fix:

Fix System.Collections.Immutable binding mismatch in Common.dll

That's a genuine correctness fix worth picking up — a binding redirect mismatch can surface as subtle runtime errors depending on transitive dependency graph resolution.

Note on CLAUDE.md Guidance

The project's CLAUDE.md states "No VSTest — use Microsoft.Testing.Platform only." Worth clarifying for future contributors: Microsoft.NET.Test.Sdk is not the VSTest runner itself — it's the MSBuild SDK package that wires up dotnet test integration and is required even when using Microsoft.Testing.Platform. The banned package is Microsoft.VisualStudio.TestPlatform. This update is consistent with the project's stated approach.

Verdict

✅ Good to merge. Straightforward patch bump with a useful bug fix and no API or behavior changes.

Code Review

PR: Bump Microsoft.NET.Test.Sdk 18.5.0 → 18.5.1

Change Summary

Single-line version bump in Directory.Packages.props:

-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />

Assessment

This update is safe and worth merging. The 18.5.1 patch specifically fixes a System.Collections.Immutable assembly binding redirect mismatch in Common.dll — a genuine correctness bug, not just a housekeeping change.

Clarification on CLAUDE.md's "No VSTest" rule: Microsoft.NET.Test.Sdk is not the banned Microsoft.VisualStudio.TestPlatform package. It is the MSBuild SDK that provides build integration for test projects and is required regardless of which test host is used. The CLAUDE.md prohibition applies to the VSTest runner, not this package.

Architecture / risk notes:

• Using centralized package versioning via Directory.Packages.props is the correct pattern — this change updates exactly one place for the entire repo.
• Patch semver bump; no API or behavioral changes upstream.
• Codacy reports zero new issues.

Verdict: ✔ Looks good. No concerns. Auto-merge is appropriate here.